C/F conversion bug in dashboard's session settings editor

paul 2015-04-01 10:51:26 UTC #1

Static set-point value is shown with Celcius units, per my preference, but the value shown is numerically the Fahrenheit temperature.

Guys - can you please prioritise fixing these C/F conversion bugs? Your non-US users will thank you! As it stands I am not confident that my Model-T won't raise the temp in my fridge up to 66 C which will melt all the shelves

Suggestion from a software engineer: store all your temperatures in Kelvin so that you have to convert for F and for C, then it'll be obvious where they don't work properly

paul 2015-04-01 10:54:45 UTC #2

In fact, I have now seen that when I saved the updated session, this happened:

my set-point prior to editing was 19.5 C
I edit the session from the web dashboard
I see the set-point displayed as '66 C' and think, "it's just a conversion rendering bug, if I don't touch it then it won't get changed"
I save the session and return to the dashboard
The dashboard now shows that the set-point has been changed to 66 C.

This is what I feared could happen.

grantanddenise1 2015-04-02 00:33:02 UTC #3

I feel your frustration on the F to C conversion. You will see that myself and other's have posted on these problems in a separate thread. The frustrating thing is it was working until the recent firmware/dashboard updates. I am also having problems with unintended steps in temperature ramps that I wonder is associated with a F to C bug also.

hebnern 2015-04-02 06:43:01 UTC #4

Thanks. We are aware of the issue and have a plan for fixing it, but haven't had a lot of time to work on it lately. If some fellow software engineer wanted to take a crack at fixing it, we would sure welcome the help

Storing the temps in K is a great idea, but would be pretty painful to change now since we have tons of data points in F in the database and flat files.

paul 2015-04-02 07:05:05 UTC #5

I'd be happy to take a look at the code. I'm not sure if I'll find time in the coming week though, am about to go on holiday over Easter.

Can you point me at the appropriate repo on github? Do you have any docs for getting started on the codebase? I assume you'd want contributors to fork and send pull requests?

hebnern 2015-04-02 07:20:00 UTC #6

The code for the dashboard lives here:

https://github.com/brewbit/brewbit-dashboard

This is a rails engine which gets pulled into the rest of the site which is in a separate private repo. The dashboard engine is not quite as standalone as it should be currently, so it might be difficult to work on in isolation. I can give you access to the main site repo if you really want to work on it. We have some rough docs for getting setup that we can publish as well. What platform are you planning to use? (We have gotten the environment setup on Mac and Linux). Yes, PRs would be great.

pdomenig 2015-04-08 07:54:03 UTC #7

I would highly appreicate if this would get some priority!

paul 2015-04-09 17:12:31 UTC #8

Hi Nick,

I'm back from holiday and started looking at this.

So I'm having trouble with the 'bundle exec rails g brewbit_dashboard:install' step. I've created a separate location for a Rails test app, and made a Gemfile with a dependency to locally-built brewbit_dashboard gem. It seems from the error as if the brewbit_dashboard generator is not registered, it doesn't appear on the list from 'rails generate --help'

Is the generator commited to the brewbit-dasboard repo? I can't find anything that looks like it. That might explain why this isn't working.

cheers
Paul

hebnern 2015-04-18 17:54:30 UTC #9

Sorry to leave you hanging. Yeah, I'm sure there is a lot of work to be done to get the dashboard gem properly extracted from our main app. We haven't paid too much attention to it because no one else has been working on it, and it only gets pulled into our app. I have sent you an invite on github giving you access to our app if you want to use that as a base. If you would like to work on properly extracting the dashboard, that would be totally welcome as well.

paul 2015-04-27 08:44:03 UTC #10

Hey Nick,
so I got things working at last and have had a poke around.
Fixing the dashboard's dynamic updates of last temp reading wasn't too hard once I'd figured out how to fake a device and it's session updates!
I've sent a pull request with the fix: https://github.com/brewbit/brewbit-dashboard/pull/4
cheers
paul

pdomenig 2015-04-29 08:41:56 UTC #11

Hope to see this change being implemented soon!

Thanky you!